GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp
Non-regression of feature/wmputman/developJune09_L91 branch
@sdrabenh is already working on this.
Since Jul 14, 2021.
- Dominant language
- Fortran
- Stars
- 10
- Forks
- 13
- Avg merge
- 17h 35m
- Merged PRs (30d)
- 14
Description
We were asked to determine why when using this branch:
feature/wmputman/developJune09_L91
the GEOSgcm.x does not pass regression test. Running with the debugging option quickly revealed that there is an unitialized variable (PTYPE) as the code crashes here:
https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/feature/wmputman%2FdevelopJune09_L91/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/GEOS_MoistGridComp.F90#L12556
If one looks PTYPE is used here but only set if DIAGNOSE_PRECIP_TYPE: TRUE but the default and what everyone has been using is this set to FALSE. If this is false PTYPE is used multiple places with no protection and results in a crash if using the debugging flags or just the non-regression in the optimized build. This needs to be cleaned up so PTYPE is protected from use if it was not filled.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.