GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp

GF is writing a fort.10 file

Open
#235 5 comments 0 reactions 4 assignees View on GitHub

@srfreita is already working on this.

Since Mar 10, 2020.

Dominant language
Fortran
Stars
10
Forks
13
Avg merge
17h 35m
Merged PRs (30d)
14

Description

This is a question for @srfreita, @wmputman, or maybe @narnold1, as well as @tclune for opinion.

Ben and I noticed today that the model now writes a fort.10 file in the scratch/ directory when run. This file seems to be coming from GF:
https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/de08f7e72dee581ab7d83730fab433c4b7db2537/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/ConvPar_GF_GEOS5.F90#L10265-L10282

I'll defer to @tclune, but I think if we want this file written, it should be named and probably opened by a more formal MAPL method.

I'm always scared to write fort.?? files because there's always a chance of code being used that expects to read fort.?? and that can take a long time to debug.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.