GEOS-ESM / GEOS-ESM/GEOSgcm_GridComp
gw_drag.F90 does not use MAPL_PI
Open
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 10
- Forks
- 13
- Avg merge
- 17h 35m
- Merged PRs (30d)
- 14
Description
π in gw_drag.F90 is not MAPL_PI:
Obviously changing this is non-zero-diff. Should we?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at line 144 of GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSgwd_GridComp/gw_drag.F90 and inspect how the π value is defined and where MAPL_PI is available. Determine whether replacing the literal would be non-zero-diff, then document the decision; completion is a clear decision on whether this change should be made.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100