GEOS-ESM / GEOS-ESM/GEOS_OceanGridComp

[ACG] OceanGridComp: complete mapl_acg migration

Open
#128 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

acg-migration mapl3-readiness
Dominant language
Fortran
Stars
2
Forks
3
Avg merge
2d 23h
Merged PRs (30d)
4

Description

Component

Name: OceanGridComp
Primary file: GEOSogcm_GridComp/@GEOS_OceanGridComp/GEOS_OceanGridComp.F90
Sub-repo: GEOS_OceanGridComp
Effort: M
MAPL depth: depth-1

Current state

  • Manual MAPL_AddImportSpec / MAPL_AddExportSpec / MAPL_AddInternalSpec calls: 15 (residual) total
  • VERIFY_( calls: 9

Notes

PARTIAL migration already present — GEOS_Ocean_Import___.h / Export___.h includes exist, but ~15 residual MAPL_AddExportSpec calls remain (mostly CHILD_ID-referencing pass-throughs). This issue completes the migration. Check whether the CHILD_ID export pattern is ACG-compatible before starting.

Links

  • Parent epic: GEOS-ESM/GEOSgcm_GridComp#1241

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with GEOSogcm_GridComp/@GEOS_OceanGridComp/GEOS_OceanGridComp.F90 and review the existing GEOS_Ocean_Import___.h and GEOS_Ocean_Export___.h includes. Inspect the remaining MAPL_AddImportSpec, MAPL_AddExportSpec, MAPL_AddInternalSpec, and VERIFY_( calls, first checking whether the CHILD_ID pass-through export pattern is ACG-compatible. Done means the residual manual MAPL calls and verification calls are migrated consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
hpc
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.