GEOS-DEV / GEOS-DEV/thirdPartyLibs
Missing declaration of zfp_init_zfp() in silo build
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4
- Forks
- 18
- Avg merge
- 9d 14h
- Merged PRs (30d)
- 4
Description
On a Mac X86 with last system updates one get this building develop branch of thirdPartiesLibs:
../../../silo/src/hdf5_drv/silo_hdf5.c:2173:5: error: call to undeclared function 'zfp_init_zfp'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
zfp_init_zfp();
^
Adding zfh.h solve the issue.
Maybe updating or patching SILO would solve it cleanly ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with silo/src/hdf5_drv/silo_hdf5.c at line 2173 and reproduce the develop-branch thirdPartiesLibs build on Mac X86. Check the reported zfh.h addition and determine whether the build succeeds without the undeclared zfp_init_zfp() error; compare whether updating or patching SILO is needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100