Unclear numbering logic for `restart_step` and `check_step`

Open
#7 0 comments 1 reaction 2 assignees View on GitHub

@CusiniM is already working on this.

Since Feb 2, 2024.

Assessment

This issue has not been assessed yet.

Description

The numbering logic for restart_step and check_step is unclear. For example, for the ContactMechanics_SimpleCubes smoke test (here) they are set to 10 and 20, respectively:

https://github.com/GEOS-DEV/integratedTests/blob/402c5a9f7ab2f3c5f123603c9db93e3feed51c12/tests/allTests/contactMechanics/contactMechanics.ats#L10-L15

However, the simulation runs for 10 cycles, ranging from 0 to 9 -- performing 11 time steps due to a time step cut. It produces three restart files:

  • ContactMechanics_SimpleCubes_smoke_restart_000000000.root
  • ContactMechanics_SimpleCubes_smoke_restart_000000005.root
  • ContactMechanics_SimpleCubes_smoke_restart_000000010.root

It is confusing what 10 and 20 stand for.

Dominant language
Python
Stars
0
Forks
1
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from GEOS-DEV/geosPythonPackages

All issues in GEOS-DEV/geosPythonPackages

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.