Change geometric shape bounded adjacency count information from absolute to relative?
Open
@wrtobin is already working on this.
Since Dec 7, 2023.
- Dominant language
- C++
- Stars
- 2
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
I think faces, edges, vertices, etc are fine names to use, but generally should be defined in terms of the dimensionality of the main geometric type.
So e.g. for an N-cube we'd talk about the N-1-faces, N-2-edges, and N-3-vertices.
So the definition of e.g. the numFaces function shouldn't be numMCubes< 2 >(), it should be based on the dimensionality of the current type and be numMCubes< DIM - 1 >().
We can also have an absolute version numAdjacent< DIM >() which replicates the current implementation (which may get more use generally).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.