GEOS-DEV / GEOS-DEV/GEOS

Issue warning for out-of-bounds initial pressure and temperature

Open
#4,128 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: feature type: new
Dominant language
C++
Stars
287
Forks
109
Avg merge
4d 41m
Merged PRs (30d)
5

Description

What is the requested feature?
A warning should be issued if table bounds are exceeded by the initial formation pressure, temperature, or XML-flagged BHP conditions. The checkTableParameter() method should be utilized for this check.

This will help highlight badly entered fluid input parameters before severe numerical problems are observed.

Describe the solution you'd like
The user should be warned by default without performance being severely impacted:
Initial formation pressure/temperature and XML BHP conditions should be checked at setup.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the setup path and the existing checkTableParameter() method first. Trace how initial formation pressure and temperature, plus XML-flagged BHP conditions, are represented and checked at setup; done means out-of-bounds values produce default warnings without a severe performance impact.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.