GEOS-DEV / GEOS-DEV/GEOS

Remove duplicate nodes from chombo coupling file

Open
#404 3 comments 0 reactions 1 assignee View on GitHub

@corbett5 is already working on this.

Since Apr 24, 2019.

Dominant language
C++
Stars
287
Forks
109
Avg merge
4d 41m
Merged PRs (30d)
5

Description

Is your feature request related to a problem? Please describe.
Duplicate (ghosted) nodes are output in the chombo coupling file.

Describe the solution you'd like
No duplicate nodes.

The proposed solution is to create a nodal field that is the index of each node in the coupling file and then sync this field using the standard method. Then we can just pass this field to the hdf5_coupler (which will need some slight modifications).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.