GEOS-DEV / GEOS-DEV/GEOS

Quasi dynamic solver clean up

Open
#3,482 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: cleanup / refactor type: new
Dominant language
C++
Stars
287
Forks
109
Avg merge
4d 41m
Merged PRs (30d)
5

Description

Describe the issue
List of cleanup steps after initial implementation of QuasiDynamic solvers.

Proposed cleanup

  • Remove duplication between dispJump_n and dispJumpOld
  • Add xml option for explicit method order.
  • Make Explicit time integrator stage tables coefficients constexpr.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the QuasiDynamic solver implementation and the Explicit time integrator stage tables, then inspect how their coefficients are currently declared. The cleanup is complete when those coefficients use constexpr and the relevant existing solver tests or validation checks still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.