GEOS-DEV / GEOS-DEV/GEOS

A designed fail test is unexpectedly passed

Open
#3,231 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: new
Dominant language
C++
Stars
287
Forks
109
Avg merge
4d 41m
Merged PRs (30d)
5

Description

I have tried to make a test expectedly fail but it is passed by the build.
Precisely, I have changed the line 132 in the test testElasticIsotropic.cpp to make it fail as follow

Initial code

EXPECT_DOUBLE_EQ( stress( 0, 0, 5 ), 0 );

Modified code to make it fail

EXPECT_DOUBLE_EQ( stress( 0, 0, 5 ), 1.0 );

However, I have observed that the build is successful with this change. I have verified that this test is well listed in the corresponding CMakeList.txt

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/coreComponents/constitutive/unitTests/testElasticIsotropic.cpp at the changed line 132, then inspect the corresponding CMakeLists.txt entry. Run the relevant test target with the modified expectation and trace whether that test is executed by the build. Done means identifying why the intentional failure does not affect the build and documenting or correcting that test execution behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.