GEOS-DEV / GEOS-DEV/GEOS

bug about Implicit Small Strain Newmark method

Open
#3,077 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug type: new
Dominant language
C++
Stars
287
Forks
109
Avg merge
4d 41m
Merged PRs (30d)
5

Description

Describe the bug
When I used the solid implicit dynamic method to calculate problems, the calculation did not converge. So I checked the relevant code. Here, you can see that detJ is not reassigned after its initial value of 0, so none of the following calculations seem to make sense.

https://github.com/GEOS-DEV/GEOS/blob/4696a656f7f586c824eb8106341e9af676981362/src/coreComponents/physicsSolvers/solidMechanics/kernels/ImplicitSmallStrainNewmark_impl.hpp#L109

I think there might be something wrong with the code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/coreComponents/physicsSolvers/solidMechanics/kernels/ImplicitSmallStrainNewmark_impl.hpp around line 109 and inspect how detJ is initialized and used. Reproduce the solid implicit dynamic calculation described in the report, then trace the relevant calculations to determine whether the suspected value causes non-convergence. Done means the defect is confirmed or ruled out and the calculation converges correctly after the appropriate change.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.