Conforming fractures solver kernels cleanup and improvements
Open
Nobody has claimed this yet.
type: new
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
- check and if possible remove
serialPolicyhere https://github.com/GEOS-DEV/GEOS/blob/d814b2213c1d15a988ff56581ecd64a25bea9dd2/src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp#L483 - convert to c-array https://github.com/GEOS-DEV/GEOS/blob/d814b2213c1d15a988ff56581ecd64a25bea9dd2/src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp#L507 and check if all others should be using stackArrays
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp at the references around lines 483 and 507. Investigate whether serialPolicy can be removed, then review the referenced array conversion and nearby uses of stackArrays. Done means the unnecessary policy is removed if applicable and the targeted array uses are converted consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc, performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100