Resolve partial overloading of `SolverBase::setConstitutiveNames` and `SolverBase::setConstitutiveNamesCallSuper`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
Describe the issue
After the MPM merge multiple overloads of the noted functions are present in SolverBase, but not all overloads are overridden in all sub-classes, this causes warnings with some build_types/compilers.
Proposed cleanup
Explicitly override the noted functions in all SolverBase subclasses, even if the implementation is just invoking the same function in the base class.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate SolverBase and enumerate its subclasses and all overloads of setConstitutiveNames and setConstitutiveNamesCallSuper. Compare which overloads each subclass overrides, then build the affected build_types with compilers that reported warnings and confirm the overloads are explicitly overridden throughout.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100