Refactor code branches based on meshBody.hasParticles()
Open
@CusiniM is already working on this.
Since May 23, 2023.
type: cleanup / refactor
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
After the merging of PR https://github.com/GEOS-DEV/GEOS/pull/1756/, there will be a few locations in the code where we will have unsightly logical branches depending on whether a meshBody is discretized with particles or not. These should be streamlined by or immediately after the meshLevel->meshDiscretization PR.
These are the specific functions as flagged by the comments below. They can also be easily found by searching for hasParticles().
ProblemManager::generateMesh: "mesh bodies with particles load their data into particle blocks, not cell blocks"ProblemManager::generateMesh: "particle mesh bodies don't have a finite element discretization"ProblemManager::setRegionQuadrature: "branch due to difference in particle vs cell regions"DomainPartition::setupCommunications: "Currently, particle-based mesh bodies do not construct their own domain decomposition"MeshManager::importFields: "field import is not currently compatible with particle mesh bodies"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.