GEOS-DEV / GEOS-DEV/GEOS

[subtask 2338] Eliminate precalc of shape functions when using GPU.

Open
#2,325 0 comments 0 reactions 1 assignee View on GitHub

@wrtobin is already working on this.

Since Mar 7, 2023.

type: feature
Dominant language
C++
Stars
287
Forks
109
Avg merge
4d 41m
Merged PRs (30d)
5

Description

The detJ and dNdx terms are currently allocated as fields and precalculated in all cases.

When running on GPU we calculate these values in the kernels instead so the above fields aren't necessary.

Further we are able to scale to a sufficient number of elements on a single GPU/MPI rank that the above fields (dNdx specifically) goes over 24gb, and hence cannot be indexed by an int32 (localIndex == int32 is required by Hypre's GPU version currently).

Currently when we calculate the mass term we assume the detJ has be precalculated.

  • Eliminate precalc of detJt and dNdx` when using GPU
  • Refactor mass calculation to use detJ if available, otherwise calculate on the fly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.