Changing some class/catalog names for coupled simulations
@francoishamon is already working on this.
Since Aug 11, 2022.
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
Describe the issue
Following up on this comment from @klevzoff, I post this issue to know if there is any objection to changing some of our catalog names and class names to have more consistent xml files in the coupled simulations.
Proposed cleanup
Changes in catalog names (following Sergey's suggestion below):
CompositionalMultiphaseFVM->MultiphaseFlowFVMCompositionalMultiphaseHybridFVM->MultiphaseFlowMimeticCompositionalMultiphaseWell->MultiphaseWell
which will be consistent with MultiphasePoromechanics in coupled simulations. Class names would be changed accordingly.
Change in attribute names:
solidSolverName->mechanicsSolverName
in the coupled simulations (as discussed during the dev meeting)
Changes in class names (don't appear in the xml, but still):
MultiphasePoromechanicsSolver->MultiphasePoromechanicsSinglePhasePoromechanicsSolver->SinglePhasePoromechanicsSinglePhasePoromechanicsSolverEmbeddedFractures->SinglePhasePoromechanicsEmbeddedFracturesFlowProppantTransportSolver->FlowProppantTransportHydrofractureSolver->HydrofractureLagrangianContactSolver->LagrangianContact
to have consistent class names between single-physics and multiphysics solvers.
I am open to better naming suggestions of course.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.