Refactor MeshLevel to Accommodate Mesh/Particle Discretization
@povolny1 is already working on this.
Since May 16, 2022.
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
Describe the issue
With the merge of #1756 into develop, a ParticleManager will be registered on any MeshLevel. Conceptually, a given MeshLevel corresponds to a given discretization (they will be renamed DiscretizationLevel or something similar soon), and so it does not make sense for a MeshLevel to contain both mesh and particle managers.
Proposed cleanup
In a discussion with @rrsettgast, @CusiniM, @TotoGaz and @homel1, it was proposed to create a base class for mesh/discretization levels and derive from it MeshDiscretization and ParticleDiscretization classes. These will only register their respective managers, removing the issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.