Nested namespace structure in solvers
Open
Nobody has claimed this yet.
type: cleanup / refactor
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
We use very long namespace names, such as ThermalCompositionalMultiphaseBaseKernels or IsothermalCompositionalMultiphaseFVMKernels.
It seems that having a more nested namespace structure might be one way to deal with it, e.g. ::geosx::flow::multiphase::kernels::isothermal or ::geosx::kernels::flow::multiphase::isothermal (we'd have to think about the order). The benefit is being able to reference any level of this hierarchy by an explicit local alias or a using directive, and thus reduce typing.
Originally posted by @klevzoff in https://github.com/GEOSX/GEOSX/pull/1225#discussion_r841341981
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.