GEOS-DEV / GEOS-DEV/GEOS

SoloEvent influencing timestep outside of application

Open
#1,774 0 comments 0 reactions 1 assignee View on GitHub

@cssherman is already working on this.

Since Feb 14, 2022.

type: bug
Dominant language
C++
Stars
287
Forks
109
Avg merge
4d 41m
Merged PRs (30d)
5

Description

Describe the bug
Defining a SoloEvent with a maxEventDt will influence the event manager dt before the target time. This should only be the case when matching the exact time for the event, or during the event.

To Reproduce

Add a SoloEvent that looks like the following:

<Events>
    <SoloEvent
      name="testEvent"
      maxEventDt="1"
      targetTime="60"/>

    <PeriodicEvent
      name="solverApplication"
      target="/Solvers/lagsolve"
      maxEventDt="60"/>
</Events>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.