Some members are references instead of objects
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
For instance, in MeshBody, m_meshLevels is a reference to a Group that is assigned to the result of a registerGroup call in its initialization list. It would be simpler to just make m_meshLevels a group that we register in the constructor.
Originally posted by @rrsettgast in https://github.com/GEOSX/GEOSX/pull/1682#r799193316
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating MeshBody and the m_meshLevels member, then inspect how registerGroup is used in its initialization list and constructor. Identify whether the same reference pattern occurs in other members, and consider the change complete when the affected members use the intended object form without breaking the project build or relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100