Allocating fields on sets
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
Is your feature request related to a problem? Please describe.
Add the capability to allocate data fields on mesh sets (e.g. element, face, vertex sets). This is needed for efficient implementation of boundary conditions that are not prescribed directly on DOFs.
Describe the solution you'd like
Proposed implementation: in ObjectManagerBase -> "sets" subgroup replace stored view wrappers of index sets with another level of subgroups that will contain the index set view wrapper along with any data fields and will be properly resized. Any loop over such a set (e.g. in BoundaryConditionBase) should pass to the user callback lambda both the mesh index and the index-within-set of the cell/face/vertex, so that user code can properly access both the globally-allocated and the set-allocated fields.
Describe alternatives you've considered
- Always allocating the fields on the full mesh (wastes a lot of memory)
- Rewriting boundary condition loops so as to avoid storing data (leads to more messy and potentially slower code)
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ObjectManagerBase and its "sets" subgroup, then trace BoundaryConditionBase loops and their callbacks. Review existing index-set view-wrapper resizing and field allocation behavior; done means set-specific fields resize correctly and callbacks expose both the mesh index and the index within the set, with corresponding tests or examples passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100