GEOS-DEV / GEOS-DEV/GEOS

Redefine public interface for `SolverBase`

Open
#1,653 3 comments 0 reactions 7 assignees View on GitHub

Nobody has claimed this yet.

type: cleanup / refactor
Dominant language
C++
Stars
287
Forks
109
Avg merge
4d 41m
Merged PRs (30d)
5

Description

Redefine public interface for SolverBase to provide access required by python scripting interface.

For example, the use of the various pre/post/initialization set of functions are not descriptive of their specific functionality, and only serve as insertion points in the initialization process. Specific functions that are indicative of the generic operations that are done, such as setSolverState or setSolverMembers, etc. should be created and called from the pre/post/initialization set of functions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.