Rework the packing function hierarchy
Open
@wrtobin is already working on this.
Since Aug 6, 2020.
type: cleanup / refactor
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
We've discussed redeveloping the packing functions for a while.
As part of this effort we should:
- Modify the
packByIndexindex set argument to allow at least bothArrayViewandSortedArrayViewto be used to pack, in order to allow time history collection to not retain an internal copy of the indices being collected. - IIRC we also use the internal copy of the packed indices to filter the ghost indices out, so that mechanism needs to be accounted for in the time-hist functionality when removing the internal set copy.
- Really this is about the higher-level packing functions in e.g. Group, which is virtual.
- Refactor the packing functions to use an
array1dto pack into instead of a raw pointer (#1285). - [ Additional cleanup items go here .. ]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.