Mark all functions declared in a cpp file static.
Open
Nobody has claimed this yet.
type: cleanup / refactor
- Dominant language
- C++
- Stars
- 287
- Forks
- 109
- Avg merge
- 4d 41m
- Merged PRs (30d)
- 5
Description
All functions declared in a .cpp file should be static. This tells the compiler that they are only ever called from that cpp file and therefore if it can tell that it's not used we'll get warnings. This will help us remove dead code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by inventorying functions declared in the repository's .cpp files and check how compiler warnings currently identify unused code. Done means the applicable functions are marked static and the resulting warnings can be used to identify dead code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers, devtools
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100