GEMScienceTools / GEMScienceTools/hamlet

stop date from start date, duration leaves out last day

Open Beginner friendly
#46 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3
Forks
2
Avg merge
1m
Merged PRs (30d)
1

Description

seis_cat_cfg = {'start_date': '1976-01-01', 'duration': 40}
get_date_parameters(seis_cat_cfg)
seis_cat_cfg

{'start_date': datetime.datetime(1976, 1, 1, 0, 0),
 'duration': 40,
 'stop_date': datetime.datetime(2015, 12, 31, 0, 0)}

stop_date should be datetime.datetime(2015, 12, 31, 23, 59).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating get_date_parameters and reproduce the issue with the seis_cat_cfg example shown. Update the date calculation so the resulting stop_date includes the final day through 23:59, then verify the returned configuration matches the expected value.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
75/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.