GEMScienceTools / GEMScienceTools/hamlet

hamlet does not process mutex ruptures correctly

Open
#14 0 comments 0 reactions 2 assignees View on GitHub

@kejohnso is already working on this.

Since Apr 4, 2023.

Dominant language
Python
Stars
3
Forks
2
Avg merge
1m
Merged PRs (30d)
1

Description

For JPN, where we expect ruptures M>9 in the source model, the model Mmax=8.4.
Using a job with only one mutex source containing several nonparametric ruptures, I found that no sources are returned by get_rlz_source. I tested what would happen if I add the following:
if len(srcs)==0:
grp = csm.src_groups[rlz]
srcs = [s for s in grp]
This works for returning sources, but gives errors due to having 0 ruptures (based on _source_info). Changing s.num_ruptures to s.count_ruptures() in lines 88 and 104 of the source_reader, hamlet will finish and create the expected plots, noting that the mutex rupture weights have not been applied and their probabilities have not been scaled to 50 yr investigation time (i.e., the rates are way too high relative to the observations).

However, keeping these changes, if I run the full ssmLT, then the original problem persists (model Mmax is again 8.4)

I'll send a test job separately

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.