GCArullo / GCArullo/JenpyROQ

Adapt to new bajes conventions

Open
#14 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
7
Forks
2
PR merge metrics
No merged PRs in 30d

Description

[Flagged by @RoxGamba]

Future `bajes` releases change the waveform interface, giving the following error:

```

Traceback (most recent call last):
File "/cluster/miniconda3-py38/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/cluster/miniconda3-py38/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/beegfs/re89yow/fd_inj_test/fd-inj/lib/python3.8/site-packages/JenpyROQ-0.0.1-py3.8.egg/JenpyROQ/__main__.py", line 146, in
File "/beegfs/re89yow/fd_inj_test/fd-inj/lib/python3.8/site-packages/JenpyROQ-0.0.1-py3.8.egg/JenpyROQ/jenpyroq.py", line 89, in __init__
File "/beegfs/re89yow/fd_inj_test/fd-inj/lib/python3.8/site-packages/JenpyROQ-0.0.1-py3.8.egg/JenpyROQ/waveform_wrappers.py", line 390, in __init__
TypeError: __init__() takes 1 positional argument but 4 were given

```

This only happens for the `dev` branch at the moment. Once this branch is merged into master, JenpyROQ interface should also be updated.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in JenpyROQ/waveform_wrappers.py around line 390, where the traceback shows the waveform interface failing during initialization. Read the surrounding wrapper and identify the expected bajes waveform arguments. Done means the wrapper works with the changed bajes waveform interface without the reported TypeError; the issue mentions the dev branch and future merge to master.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.