G-Node / G-Node/nixpy

Support case insensitive LinkType name in Feature creation

Open
#398 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
22
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Note by @hkchekc on specifying LinkType in Feature creation after switching to Enums: https://github.com/G-Node/nixpy/pull/395#issuecomment-494399010

> @gicmo while the idea is great and being merged, I just want to note that the by-product (supporting old strings) is not going to work (at least not completely). In the past, the string 'Tagged' with the first letter capitalized works. Now the valid string parameter input should be all lower-case. For example, 'tagged'

Ah true, I guess for that a `.lower()` call would need to be added now. I have no strong opinion about supporting it (or not). @jgrewe what do you think?

_Originally posted by @gicmo in https://github.com/G-Node/nixpy/pull/395#issuecomment-494404537_

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Feature creation path and the LinkType handling discussed in PR 395 and its linked comments. Confirm how string names are converted, then make the existing capitalized form such as "Tagged" work alongside the lowercase form and verify both inputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.