G-Node / G-Node/nix

Mark overridden functions with 'override'

Open
#537 0 comments 0 reactions 1 assignee Claimed by @gicmo View on GitHub
code quality enhancement
Dominant language
C++
Stars
72
Forks
36
PR merge metrics
No merged PRs in 30d

Description

New versions of clang (here: `Apple LLVM version 7.0.0 (clang-700.0.72)`) warn (`-Winconsistent-missing-override`) for functions that override but are not marked as such. I think that this is a good practice that should be adopted and even be put in Contributing.md.
Currently we have tons for such warnings. I might fix them peu à peu.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.