G-Node / G-Node/nix

NDSizeBase::ctor code duplication

Open
#501 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
72
Forks
36
PR merge metrics
No merged PRs in 30d

Description

With pull request #500 we have duplicated code in the `NDSizeBase(std::initializer_list args)` and the `NDSizeBase(const std::vector &args)` constructor. We should some get rid of this one way or the other. Maybe an additional constructor that takes `NDSizeBase(const std::valarray &args)` that other ctors delegate to could help.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.