G-Node / G-Node/nix

DataTag ctor throwing errors

Open
#305 0 comments 0 reactions 0 assignees View on GitHub
invalid model improvements
Dominant language
C++
Stars
72
Forks
36
PR merge metrics
No merged PRs in 30d

Description

Currently the `DataTag` ctor will throw errors if an invalid `DataTag` is opened: it uses the `positions` method to set the supplied obligatory `DataArray` as `positions` array. This is not a good situation, as the error will obstruct every other operation (e.g. validation) one could want to perform on the `DataTag`. Thus we should perhaps consider not doing any kind of check in the ctor and set the supplied `DataArray`'s `id` no matter what.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.