G-Node / G-Node/nix

deletingEntities is pretty unsafe

Open
#138 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
72
Forks
36
PR merge metrics
No merged PRs in 30d

Description

Just stumbled over a strange behavior:

```
Section section = file.createSection("testSection");
file.deleteSection(section.id());
section.createProperty("testProperty"); //passes without complaint
```

Not sure, but what do you think about changing deleters to:

```
deleteEntity(Entity &entity);
```

this would allow the deleter to set the enity to none_t.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.