Deploy keys not working
Open
- Dominant language
- JavaScript
- Stars
- 16
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
Introduced in 949813e53, deploy keys don't work because the the git service returns an error when a key does not belong to a user:
https://github.com/G-Node/gogs/blob/25d9f550419046d3cc7d6872aff14fbe006977c0/internal/cmd/serv.go#L197-L201
Relevant issue on GIN: https://gin.g-node.org/G-Node/Info/issues/33
Contributor guide
Research direction
Start at internal/cmd/serv.go lines 197-201, where the deploy-key failure is reported, and compare the behavior with the related GIN issue 33. Trace how the git service handles keys that do not belong to a user; done means deploy keys authenticate successfully in that case and the relevant behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100