G-Node / G-Node/gin-valid

Proper status codes

Open
#87 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Go
Stars
0
Forks
3
PR merge metrics
No merged PRs in 30d

Description

The function `TestValidateTMPFail` tests that the validation fails, but because the problem is correctly delivered to the user, the result code of the request is 200 OK. The same applies to the test function `TestValidateBadgeFail`.

https://github.com/G-Node/gin-valid/blob/5683eb96962234ed3cecd687aed274af9324560e/internal/web/validate_test.go#L170
https://github.com/G-Node/gin-valid/blob/5683eb96962234ed3cecd687aed274af9324560e/internal/web/validate_test.go#L77
Are the results codes obtained from the tested functions correct in this case?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.