FuelLabs / FuelLabs/forc

Checksum Validation Bug in account.rs

Open
#11 1 comment 0 reactions 0 assignees View on GitHub
bug forc-wallet
Dominant language
Rust
Stars
0
Forks
0
Avg merge
1d 22h
Merged PRs (30d)
3

Description

Hey team! 👋 I was digging into the account.rs file and noticed something off with the checksum validation logic for Ethereum addresses around line 45.

Looks like the current implementation doesn’t fully handle cases where checksums aren't matching correctly. To fix this, I’d suggest using a stricter validation method that re-checks the checksum based on a standard like EIP-55. This would ensure we're catching all invalid addresses and preventing any weird edge cases from slipping through.

Proposed fix:

if !is_checksum_valid(s) {
return Err("Invalid checksum for Ethereum address. Please check again.");
}

Let me know what you think! Happy to help with the fix if needed.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in account.rs around line 45 and inspect the existing Ethereum address checksum validation. Compare its behavior with the EIP-55 standard and determine which mismatches are currently accepted; the work is done when invalid checksums are rejected with the stated error without weakening valid-address handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
blockchain, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.