"!search name:/!/" isn't parsed correctly
- Dominant language
- Go
- Stars
- 6
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
Root cause is that our botcommand regex @ https://github.com/Fryyyyy/Fryatog/blob/master/utils.go#L26 doesn't handle this properly.
I vaguely remember talking about this when we originally implemented the `!search` command. Do we want to only handle it if it's the whole line? Like, we only capture the command for this if `!search` starts the line, and if it does, we ship the entire line to the scryfall API.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at utils.go line 26, where the botcommand regex is defined, and inspect how !search input is passed to the Scryfall API. Reproduce the !search name:/!/ parsing case and clarify whether commands must start the line and whether the whole line should be forwarded; done means this input is parsed as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100