FriendsOfFlarum / FriendsOfFlarum/split
Modal didn't disappear after split the discussion
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 12
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
Bug Report
Tag changing modal doesn't disappear when I split post from the original one to under the new discussion. I don't know it's happening because of FoF Split but I wanted to report it.
Steps to Reproduce
- Go to a discussion
- Click on arrow and click Spilt
- Create a new discussion
- Change the tag and save or close the modal
Expected Behavior
The modal should be closed after saving the changes or closing the model.
Environment
- Flarum version: 1.8.5
- Extension version: 1.1.1
- Website URL: https://support.bw.agency
- Webserver: nginx
- Hosting environment: Shared
- PHP version: 8.0.26
- Browser: All browsers
Flarum core: 1.8.5
PHP version: 8.0.26
MySQL version: 8.0.31-cll-lve
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bz2, calendar, ctype, curl, hash, filter, ftp, gettext, gmp, SPL, iconv, json, pcntl, readline, Reflection, session, standard, shmop, SimpleXML, mbstring, tokenizer, xml, i360, bcmath, dom, fileinfo, gd, igbinary, imagick, imap, intl, exif, mcrypt, mysqlnd, mysqli, PDO, pdo_mysql, pdo_sqlite, Phar, posix, soap, sockets, xmlreader, xmlwriter, xsl, zip, Zend OPcache
+------------------------------------+---------+--------+
| Flarum Extensions | | |
+------------------------------------+---------+--------+
| ID | Version | Commit |
+------------------------------------+---------+--------+
| flarum-tags | v1.8.0 | |
| flarum-mentions | v1.8.3 | |
| flarum-subscriptions | v1.8.0 | |
| fof-sitemap | 2.2.1 | |
| fof-impersonate | 1.1.1 | |
| flamarkt-backoffice | 0.1.3 | |
| fof-follow-tags | 1.2.2 | |
| flarum-markdown | v1.8.0 | |
| webbinaro-calendar | 1.7.0 | |
| v17development-user-badges | v1.1.0 | |
| v17development-seo | v1.8.0 | |
| tohsakarat-tags-filter | v1.0.5 | |
| sycho-private-facade | v0.1.16 | |
| nearata-internal-links-noreload | v2.2.0 | |
| ianm-boring-avatars | 1.0.0 | |
| ganuonglachanh-search | 0.5.2 | |
| fof-upload | 1.5.4 | |
| fof-split | 1.1.1 | |
| fof-pretty-mail | 1.1.2 | |
| fof-polls | 2.1.2 | |
| fof-moderator-notes | 1.2.2 | |
| fof-merge-discussions | 1.4.1 | |
| fof-links | 1.2.2 | |
| fof-linguist | 1.1.2 | |
| fof-formatting | 1.0.3 | |
| fof-default-user-preferences | 1.2.1 | |
| fof-best-answer | 1.4.1 | |
| flarum-suspend | v1.8.1 | |
| flarum-sticky | v1.8.0 | |
| flarum-pusher | v1.8.0 | |
| flarum-nicknames | v1.8.0 | |
| flarum-lock | v1.8.0 | |
| flarum-lang-turkish | 1.25.0 | |
| flarum-extension-manager | v1.0.2 | |
| datlechin-simple-tour-guide | v0.0.1 | |
| datlechin-offline-indicator | v0.1.0 | |
| datlechin-keyboard-shortcuts | v0.1.1 | |
| datlechin-discussion-overview | v0.0.1 | |
| club-1-cross-references | v1.1.1 | |
| clarkwinkelmann-who-read | 1.4.1 | |
| clarkwinkelmann-post-stream-search | 1.1.0 | |
| blomstra-turnstile | 0.1.4 | |
| blomstra-sort-order-toggle | 0.2.0 | |
| blomstra-database-queue | 1.1.0 | |
| blomstra-cache-assets | 0.5 | |
| betterflarum-bettermobiledrawer | 2.2.0 | |
| askvortsov-pwa | v3.3.3 | |
| askvortsov-markdown-tables | v1.2.1 | |
| askvortsov-help-tags | v1.1.0 | |
| askvortsov-checklist | v1.3.1 | |
| acpl-lscache | v2.3.1 | |
+------------------------------------+---------+--------+
Base URL: https://support.bw.agency
Installation path: /home/samsunek/support.bw.agency
Queue driver: database
Session driver: file
Scheduler status: Aktif
Mail driver: smtp
Debug mode: off
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the split flow in Flarum 1.8.5 with fof-split 1.1.1: split a post, create a discussion, then change its tag and save or close the modal. The issue is done when the tag-changing modal closes correctly after both actions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100