FreshRSS / FreshRSS/FreshRSS

[Feature] Change .onclick handlers to addEventlistener

Open
#3,903 0 comments 0 reactions 0 assignees View on GitHub
Not urgent :snail: System care
Dominant language
PHP
Stars
16k
Forks
1.3k
Avg merge
13h 24m
Merged PRs (30d)
40

Description

**Is your feature request related to a problem? Please describe.**

Using .onclick is generally considered undesirable. I seem to have overlooked them in #2234.

**Describe the solution you'd like**
Replace by addEventListener.

**Describe alternatives you've considered**
Leaving it as is, but see https://github.com/FreshRSS/FreshRSS/pull/3901 for why that's probably not the best idea. People will unsuspectingly copy it.

**Additional context**
There are others like .onerror.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.