FreeTubeApp / FreeTubeApp/FreeTube

Standardize link sharing menu across app and remove old type

Open
#1,450 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Vue
Stars
21.9k
Forks
1.5k
Avg merge
1d 14h
Merged PRs (30d)
62

Description

**Is your feature request related to a usage problem (not a bug)? Please describe.**
The sharing menu is not standardized across FreeTube. When sharing a video using the normal button when playing a video, a nice-looking dropdown is shown with options to copy links. However, when sharing a playlist, playlist video, suggested video, basically anywhere else than video page with search, shows the old list-type dropdown which is annoying to look through,

**Describe the solution you'd like to see implemented**
Port the same menu (without -> (O ) Include Timestamp) to all instances where the old list-type dropdown is shown.
For different options, just change the menu slightly.
Buttons could also have a grey background rather than blue, if it was more fitting.

Spots that need to change:
- Up Next
- Subs, trending, etc & search
- Playlist pages
- Playlist indexes
- Channel pages

**Describe alternatives you've considered**
Sort the list-type menu like this (not ideal):
![image](https://user-images.githubusercontent.com/72892531/123445247-9f26d180-d5cf-11eb-9c8f-d512b4e82032.png)

**Screenshots**
Old list-type menu:
![image](https://user-images.githubusercontent.com/72892531/123445339-b4036500-d5cf-11eb-9aca-54b40fa769aa.png)

Newer menu that should be used instead (already used on video pages):
![image](https://user-images.githubusercontent.com/72892531/123445416-c1b8ea80-d5cf-11eb-9fa3-a140fb24a256.png)

**Additional context**
I also want to note that I would recommend against the current display of playlist share menus - it pushes the video out of sight and cuts of the bottom. I would advise to increase the z-index of the menu and to have it display over the playlist list div.
![image](https://user-images.githubusercontent.com/72892531/123445708-1197b180-d5d0-11eb-99e8-0222bf61ec4c.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.