FreeCAD / FreeCAD/FreeCAD

PartDesign: Add additional checks in `PartDesignGui::isFeatureMovable()` for Link-based referenced geometry

Open
#9,528 0 comments 1 reaction 0 assignees View on GitHub
Mod: Part Design Topic: Link Topic: Shapebinder Type: Feature
Dominant language
C++
Stars
33.6k
Forks
6k
Avg merge
3d 17h
Merged PRs (30d)
196

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Forums discussion

_No response_

### Version

0.21 (Development)

### Full version info

```
OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.21.0.33110 (Git)
Build type: Release
Branch: master
Hash: 18e40941ceb36c52701a7c74ea26043ef3385701
Python 3.10.10, Qt 5.15.8, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: Russian/Russia (ru_RU)
```

### Subproject(s) affected?

PartDesign

### Issue description

The function `PartDesignGui::isFeatureMovable(App::DocumentObject* const feat)` checks whether sketch is movable even if there is none.

There are no checks of Link-based referenced geometry, like (Sub)ShapeBinder.

### Anything else?

Discussed at #9398.

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.