FreeCAD / FreeCAD/FreeCAD

Measurement: unsaved measure are a document modification

Open
#13,735 3 comments 1 reaction 0 assignees Claimed by @theo-vt View on GitHub
Mod: Core Mod: Measurement Topic: User Interface Type: Feature
Dominant language
C++
Stars
33.6k
Forks
6k
Avg merge
3d 17h
Merged PRs (30d)
196

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Problem description

How to reproduce:

1. Open an existing file and create a new one.
2. Measure something but don’t click on Annotate.
3. The document is marked as modified.
4. Cancel the measurement.
5. The document is still marked as modified.

Indeed, there the measurement in the design tree but it goes away is left unsaved. This can lead to problems when working with assemblies and multiple files because the programs can believe that there are modified files when they aren’t and save them when they shouldn’t. This can be especially annoying when working with a PDM.

### Full version info

```shell
OS: Ubuntu 23.10 (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37063 (Git) AppImage
Build type: Release
Branch: main
Hash: 680792030fd664c94829e2c1b78b21788e8d9879
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: French/France (fr_FR)
Installed mods:
* BillOfMaterials-WB 0.0.7
* CosmeticThread3D
* OpenTheme 2024.4.20
* Curves 0.6.35
* CurvedShapes 1.0.9
* sheetmetal 0.4.13
```

### Subproject(s) affected?

None

### Anything else?

On save management of files: #12680.

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Research direction

Reproduce the five steps in the issue using an existing file and a new file, then inspect how measurement creation, cancellation, and document-modified state are handled. Review linked pull request #22100 and verify that canceling an unsaved measurement no longer leaves the document marked modified, including the assembly and multiple-file scenario.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.