FredKSchott / FredKSchott/rollup-plugin-polyfill-node

crypto and fs shims are not compiled

Open
#83 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
193
Forks
60
PR merge metrics
No merged PRs in 30d

Description

The current release does not shim `fs` and `crypto`. The current crypto tests pass only because there is no positive test for expected values vs unexpected values.

Additionally, tests has note about including/excluding `crypto:true` which I think isn't actually used in the implementation.

https://github.com/FredKSchott/rollup-plugin-polyfill-node/blob/31face71b94b8408a907f04753318dff589adc2f/scripts/build-polyfills.js#L12

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.