Frameright / Frameright/image-display-control-web-component

Fix circular imports

Open
#8 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
18
Forks
1
PR merge metrics
No merged PRs in 30d

Description

```
$ npm run build
[...]
┌──────────────────────────────┬──────────┐
│ File name │ Size │
│ ---------------------------- │ -------- │
│ image-display-control.min.js │ 17.88 kB │
│ ---------------------------- │ -------- │
│ Totals │ 17.88 kB │
└──────────────────────────────┴──────────┘
(!) Circular dependencies
dist/src/PositionInRelativeCoord.js -> dist/src/PositionInPixels.js -> dist/src/PositionInRelativeCoord.js
dist/src/SizeInPixels.js -> dist/src/SizeInRelativeCoord.js -> dist/src/SizeInPixels.js
created ./dist/image-display-control.min.js in 546ms
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Run `npm run build` and inspect the reported dependency cycles between dist/src/PositionInRelativeCoord.js and PositionInPixels.js, and between dist/src/SizeInPixels.js and SizeInRelativeCoord.js. Trace these cycles back to their TypeScript sources and remove the circular imports; done means the build completes without either circular-dependency warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.