FormidableLabs / FormidableLabs/victory

Audit and remove magic numbers (all projects)

Open
#573 4 comments 0 reactions 0 assignees View on GitHub
Issue: Accepted
Dominant language
TypeScript
Stars
11.2k
Forks
536
PR merge metrics
No merged PRs in 30d

Description

Our incoming new lint does detect `magic-numbers`, and most have just been disabled for compatibility.

Task

- [x] Come up with archetype config base rule, e.g. `no-magic-numbers: ["error", { "ignore": [-1, 0, 0.5, 1, 2] }]` or something.
- [ ] Grep on `no-magic-numbers` in all projects and audit usage / abstract to constants where sensible.
- [x] Search on string `// TODO: magic numbers`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.