FormidableLabs / FormidableLabs/victory

Type Error in Victory Container 36.9.1

Open
#2,815 3 comments 0 reactions 0 assignees View on GitHub
Issue: Accepted Type: Bug :bug:
Dominant language
TypeScript
Stars
11.2k
Forks
536
PR merge metrics
No merged PRs in 30d

Description

I am using victory `36.9.1` and react `18.2` in node 20

It is all working in production currently on node 16, react 17 using victory `35.4.8`

I am trying to create a voronoi zoom container
```ts
import { VictoryVoronoiContainerProps } from 'victory-voronoi-container';
import { VictoryZoomContainerProps } from 'victory-zoom-container';
```
When I create the container I get a type error:

```ts
const VictoryZoomVoronoiContainer = createContainer(
'zoom',
'voronoi',
);
```

```
Expected 0 type arguments, but got 2.ts(2558)
```

Apologies in advance if this is my fault and is a question best directed elsewhere.

_Originally posted by @eatyourpeas in https://github.com/FormidableLabs/victory/issues/1446#issuecomment-1950179439_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the TypeScript error with Victory 36.9.1, React 18.2, and the shown createContainer call. Inspect the createContainer entry point and its exported type declarations, then compare the behavior with Victory 35.4.8. Done means the documented zoom-plus-voronoi container composition type-checks successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
data-visualization, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.