FormidableLabs / FormidableLabs/victory
Convert class components to function components
- Dominant language
- TypeScript
- Stars
- 11.2k
- Forks
- 536
- PR merge metrics
- No merged PRs in 30d
Description
# Motivation
Most of the Victory components are classes. We should look at converting these to function components to simplify things a little and improve developer experience.
# Components to convert
Some of these components may need to be converted simultaneously, and in some cases, it may make more sense to use component composition over class inheritance.
- [x] victory-container #2799
- [ ] add-events
- [ ] victory-clip-container
- [ ] victory-transition
- [x] victory-portal #2799
- [x] victory-zoom-container #2799
- [x] victory-voronoi-container #2799
- [x] victory-cursor-container #2799
- [x] victory-brush-container #2799
- [x] victory-selection-container #2799
- [ ] victory-bar
- [x] victory-animation #2788
- [x] victory-accessible-group #2777
- [ ] victory-voronoi
- [ ] victory-tooltip
- [ ] victory-shared-events
- [ ] victory-scatter
- [ ] victory-polar-axis
- [ ] victory-pie
- [ ] victory-line
- [ ] victory-legend
- [ ] victory-histogram
- [ ] victory-errorbar
- [x] victory-create-container #2799
- [ ] victory-candlestick
- [ ] victory-brush-line
- [ ] victory-box-plot
- [ ] victory-axis
- [ ] victory-area
Contributor guide
Assessment
This issue has not been assessed yet.