FormidableLabs / FormidableLabs/victory

Unable to wrap victory components into customizable components

Open
#2,342 7 comments 0 reactions 0 assignees View on GitHub
Issue: Accepted Type: Enhancement :pencil2:
Dominant language
TypeScript
Stars
11.2k
Forks
536
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
When I try to wrap Victory components like VictoryLine or VictoryBar, the graph is not plotted for reasons unknown.

**Describe the solution you'd like**
Need to get Victory component wrapped to my custom component thereby plotting chart smoothly as expected.

**Describe alternatives you've considered**
I tried mentioning the roles like below, but no luck.
MyCustomLine.role = 'line';

**Additional context**
Below is the Codesandbox link demonstrating the sample application I am trying. It contains the examples of working one wherein Victory component is directly used and not working one, wherein Victory component is wrapped up
https://codesandbox.io/s/victory-wrapper-p6ffzy?file=/src/App.tsx

Please let me know if I am missing something to get my chart plotted using my wrapped component.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.