FormidableLabs / FormidableLabs/victory

Fix label spacing and text size approximation to support non-latin characters and RTL

Open
#2,108 3 comments 0 reactions 0 assignees View on GitHub
Issue: Accepted Type: Enhancement :pencil2:
Dominant language
TypeScript
Stars
11.2k
Forks
536
PR merge metrics
No merged PRs in 30d

Description

This is an issue to overhaul how label size is determined. Right now, label size is approximated using the size of specific characters in specific fonts, but this does not adapt to custom fonts, non-Latin character sets, and RTL text.

This solution might require some discussion - right now the only proposed fix for this would be to pre-render the text with a CSS rule like `visibility: hidden`, measure the text, and re-render the text with the correct spacing. Are there other solutions to this problem?

Note for contributors: This issue is most likely a medium time commitment (1 week or more), but doesn't touch as much of the complex Victory internals.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.