FormidableLabs / FormidableLabs/victory-native-xl

isActive doesn't reliably change to false at the end of a gesture

Open
#263 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.2k
Forks
109
Avg merge
1d 15h
Merged PRs (30d)
3

Description

### Describe Your Environment

**What version of victory-native-xl are you using?** 40.1.1

**What version of React and React Native are you using?** react 18.2.0, react-native 0.73.6

**What version of Reanimated and React Native Skia are you using?** reanimated 3.8.1, skia 0.1.221

**Are you using Expo or React Native CLI?** expo

**What platform are you on?** (e.g., iOS, Android) iOS

### Describe the Problem

When performing a pan gesture on a CartesianChart, `isActive` sometimes remains `true` at the end of the gesture. I was able to reproduce this issue in the example app. My app implements very similar logic.

https://github.com/FormidableLabs/victory-native-xl/assets/2230992/d3afa018-bc65-468a-a257-e0e8bff82b78

**Expected behavior:** At the end of the gesture, `isActive` should become `false` and the text below the chart [should revert to "Single or multi-touch the chart"](https://github.com/FormidableLabs/victory-native-xl/blob/main/example/app/stock-price.tsx#L67)

**Actual behavior:** `isActive` sometimes remains `true` at the end of the gesture, so that the text below the chart [continues to display the last-touched value](https://github.com/FormidableLabs/victory-native-xl/blob/main/example/app/stock-price.tsx#L70).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.